Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vrf test #403

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Improve vrf test #403

merged 5 commits into from
Apr 18, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Apr 14, 2022

Description

  • Refactor
  • Take out and remake
    • crypto/vrf/compatibility_keys_test.go
    • crypto/vrf/compatibility_vrf_test.go
  • Add hdevalence/ed25519consensus for test

@tnasu tnasu marked this pull request as ready for review April 14, 2022 05:41
@tnasu tnasu requested review from Kynea0b and torao as code owners April 14, 2022 05:41
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #403 (4aec07e) into main (9615276) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   65.16%   65.30%   +0.14%     
==========================================
  Files         277      277              
  Lines       37832    37872      +40     
==========================================
+ Hits        24653    24734      +81     
+ Misses      11373    11325      -48     
- Partials     1806     1813       +7
Impacted Files Coverage Δ
crypto/vrf/vrf_libsodium.go 78.57% <100.00%> (ø)
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
crypto/ed25519/ed25519.go 45.12% <0.00%> (-1.22%) ⬇️
mempool/reactor.go 78.57% <0.00%> (-1.10%) ⬇️
p2p/switch.go 65.08% <0.00%> (-0.83%) ⬇️
mempool/clist_mempool.go 82.41% <0.00%> (-0.68%) ⬇️
light/client.go 61.61% <0.00%> (-0.45%) ⬇️
privval/file.go 74.90% <0.00%> (-0.10%) ⬇️
mempool/errors.go 25.00% <0.00%> (ø)
blockchain/v0/pool.go 78.81% <0.00%> (ø)
... and 11 more

@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Apr 15, 2022
Kynea0b
Kynea0b previously approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torao
torao suggested changes Apr 15, 2022
View reviewed changes
crypto/vrf/vrf_r2ishiguro_test.go Outdated Show resolved Hide resolved
torao
torao approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit 57392cc into Finschia:main Apr 18, 2022
@tnasu tnasu deleted the main-improve-vrf-test branch April 28, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b